[Webkit-unassigned] [Bug 165225] UIViewController with WkWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #20 from Brad Wright <bwright2 at apple.com> ---
(In reply to comment #17)
> Comment on attachment 302902 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302902&action=review
> 
> > Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:583
> > +    _presentationViewController = nil;
> 
> I don't think there's any purpose in keeping the _presentationViewController
> ivar if it's going to be nil in all circumstances outside of this method. Is
> this approach any different than just removing
> 
>     if (_presentationViewController) {
>         [_presentationViewController dismissViewControllerAnimated:animated
> completion:^{
>             _presentationViewController = nil;
>         }];
>     }
> 
> in -_dismissDisplayAnimated:?

I found that the _presentationViewController should not be removed.  I went down the path of removing it, and found that it potentially needed in the class's dismiss routine which was being called externally.  I found that the much easier solution was to simply set the _presentationViewController to nil when the UIDocumentMenuViewController controller was being presented.  Overall, this makes the proposed changes much smaller.  It reduces the risk of any regression bugs from this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/570abc55/attachment.html>