[Webkit-unassigned] [Bug 165225] UIViewController with WkWebView presented modally causes the presented UIViewController to be dismissed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 19:31:00 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #17 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 302902
  --> https://bugs.webkit.org/attachment.cgi?id=302902
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302902&action=review

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:583
> +    _presentationViewController = nil;

I don't think there's any purpose in keeping the _presentationViewController ivar if it's going to be nil in all circumstances outside of this method. Is this approach any different than just removing

    if (_presentationViewController) {
        [_presentationViewController dismissViewControllerAnimated:animated completion:^{
            _presentationViewController = nil;
        }];
    }

in -_dismissDisplayAnimated:?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170228/8812e908/attachment.html>


More information about the webkit-unassigned mailing list