[Webkit-unassigned] [Bug 163892] [GTK] Add function webkit_dom_element_get_bounding_client_rect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 14:26:06 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=163892

--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #10)
> (In reply to comment #8)
> > > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp:118
> > > +static GObject* webkit_dom_client_rect_constructor(GType type, guint constructPropertiesCount, GObjectConstructParam* constructProperties)
> > 
> > I think you can use constructed for this instead of constructor. It would be
> > a lot simpler.
> 
> Not sure what you mean by this. I've fixed the other complaints.

Try implementing the constructed virtual method, rather than the constructor virtual method:

https://developer.gnome.org/gobject/stable/gobject-The-Base-Object-Type.html#GObjectClass

constructed is simpler, but is called after properties have already been set. I don't think it matters in your case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170227/d6f8f1cb/attachment.html>


More information about the webkit-unassigned mailing list