[Webkit-unassigned] [Bug 163892] [GTK] Add function webkit_dom_element_get_bounding_client_rect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163892

--- Comment #10 from aidanholm+webkit at gmail.com ---
(In reply to comment #8)
> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp:118
> > +static GObject* webkit_dom_client_rect_constructor(GType type, guint constructPropertiesCount, GObjectConstructParam* constructProperties)
> 
> I think you can use constructed for this instead of constructor. It would be
> a lot simpler.

Not sure what you mean by this. I've fixed the other complaints.

> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp:143
> > +            "read-only gfloat ClientRect:top",
> 
> Ahaha, not a very good property description. :P  I guess it's fine, though,
> since it's the style used by existing DOM objects.

When in Rome... I've had the same thought while browsing the docs :)

> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h:532
> > + * Returns: (element-type WebKitDOMClientRect) (transfer full): A #GList
> 
> Is it really transfer full, or is it actually transfer container (where the
> GList itself is owned by the caller, but the elements are unowned)? It's not
> clear to me from the implementation. i.e., do you free the list with
> g_list_free(list) or with g_list_free_full(list, g_object_unref)?

Actually, I think the way I implemented it currently is transfer full for both functions... I'm still getting used to WebKit's refcounting system. I'll try to change that to transfer none and transfer container, since that seems more user-friendly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170227/361f621a/attachment-0001.html>