[Webkit-unassigned] [Bug 168871] [GTK] Downloads attributes tests are failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168871

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 302784 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302784&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        differently but download success.
> 
> success -> succeeds

Oops.

> > Source/WebCore/ChangeLog:9
> > +        Use libsoup to get the suggested filename from the Content-Disposition header instead of buggy
> > +        filenameFromHTTPContentDisposition().
> 
> What is buggy about it? Shouldn't we fix that bug, especially if it's
> affecting all ports? It sounds like it requires a adding FIXME at least?

It's buggy because there's already a FIXME comment explaining it:

// FIXME: This function doesn't comply with RFC 6266.                                                                                                                                         
// For example, this function doesn't handle the interaction between " and ;                                                                                                                  
// that arises from quoted-string, nor does this function properly unquote                                                                                                                    
// attribute values. Further this function appears to process parameter names                                                                                                                 
// in a case-sensitive manner. (There are likely other bugs as well.)                                                                                                                         
String filenameFromHTTPContentDisposition(const String& value)

It doesn't affect other ports, it's only used by curl backend, I think. I don't even know what other port is using curl, I guess it's WinCairo.

> I'd rather use libsoup to get the filename *inside* the implementation of
> filenameFromHTTPContentDisposition if need be. Avoiding use of
> filenameFromHTTPContentDisposition feels like a workaround.

I don't think so, I see filenameFromHTTPContentDisposition as a platform independent fallback implementation when your platform code doesn't provide a better way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170227/89cf05b4/attachment.html>