[Webkit-unassigned] [Bug 168871] [GTK] Downloads attributes tests are failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168871

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302784|commit-queue-               |
              Flags|                            |

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 302784
  --> https://bugs.webkit.org/attachment.cgi?id=302784
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302784&action=review

> LayoutTests/ChangeLog:10
> +        differently but download success.

success -> succeeds

> Source/WebCore/ChangeLog:9
> +        Use libsoup to get the suggested filename from the Content-Disposition header instead of buggy
> +        filenameFromHTTPContentDisposition().

What is buggy about it? Shouldn't we fix that bug, especially if it's affecting all ports? It sounds like it requires a adding FIXME at least?

I'd rather use libsoup to get the filename *inside* the implementation of filenameFromHTTPContentDisposition if need be. Avoiding use of filenameFromHTTPContentDisposition feels like a workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170226/5036fc19/attachment-0001.html>