[Webkit-unassigned] [Bug 168816] Rename 'commit_parent' in 'commits' table to 'commit_previous_commit'.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168816

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302630|review?                     |review+
              Flags|                            |

--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 302630
  --> https://bugs.webkit.org/attachment.cgi?id=302630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302630&action=review

r=me with previous_commit > previousCommit in JSON API.

> Websites/perf.webkit.org/public/include/commit-log-fetcher.php:124
> -            'parent' => $commit_row['commit_parent'],
> +            'previous_commit' => $commit_row['commit_previous_commit'],

We should be using camelCase for JSON API.

> Websites/perf.webkit.org/tools/sync-commits.py:234
> -            'parent': parent_hash,
> +            'previous_commit': previous_hash,

This should also be previousCommit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170224/8daf8d66/attachment.html>