[Webkit-unassigned] [Bug 163159] [GTK] Crash attempting to load Flash plugin in Wayland

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 08:22:52 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=163159

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #11)
> Comment on attachment 302498 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302498&action=review
> 
> This looks better.
> 
> > Source/WebKit2/UIProcess/gtk/WebPageProxyGtk.cpp:106
> > +    ASSERT(WebCore::PlatformDisplay::sharedDisplay().type() == WebCore::PlatformDisplay::Type::X11);
> 
> r=me if and only if you change this to CRASH() or RELEASE_ASSERT().

This message is not sent by the plugin process (untrusted) but by the web process (trusted) so I don't think we need a release assert. I added it only to make you happy, not because I think is needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170223/5383257f/attachment.html>


More information about the webkit-unassigned mailing list