[Webkit-unassigned] [Bug 168029] Web Inspector: Network tab content view is blank after reload

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 13:27:14 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=168029

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302429|review?                     |review-
              Flags|                            |

--- Comment #6 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 302429
  --> https://bugs.webkit.org/attachment.cgi?id=302429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302429&action=review

Usually we require each change in WebKit to include a regression test. You can see some examples in LayoutTests/inspector. Your patch should include a regression test or, in those rare cases, an explanation of why no test is possible in this case.

> Source/WebInspectorUI/ChangeLog:9
> +        (WebInspector.NetworkSidebarPanel.prototype._networkTimelineReset):

This is a good place to explain your understanding of the bug, and why your change makes things better.

> Source/WebInspectorUI/ChangeLog:19
> +2017-02-22  Sam Brodkin  <isam at apple.com>
> +
> +        Web Inspector: Network tab content view is blank after reload
> +        https://bugs.webkit.org/show_bug.cgi?id=168029
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UserInterface/Views/NetworkSidebarPanel.js:
> +        (WebInspector.NetworkSidebarPanel.prototype._networkTimelineReset):

Looks like prepare-ChangeLog ran twice. Better to remove the second entry.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170222/f608cdec/attachment-0001.html>


More information about the webkit-unassigned mailing list