[Webkit-unassigned] [Bug 168737] New: AutoInstaller should not skip the install step if the package is downloaded but not installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168737

            Bug ID: 168737
           Summary: AutoInstaller should not skip the install step if the
                    package is downloaded but not installed
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: lforschler at apple.com, youennf at gmail.com

When installing a python library for the tests via AutoInstaller, there is an optional argument "should_refresh" that can be defined to instruct the installer to always re-download and re-install such package.


The issue is that "should_refresh" only checks if the source tarball is downloaded, but it ignores the fact that it can be already installed or not

This can happen if the user manually cleans the installation folder for the auto-installed python libraries or if the installation of the library failed previously for any reason.

So... what ends happening is that the module never gets installed.

This has bitten me, I was cleaning the automatically installed wpt-tools library at LayoutTests/imported/w3c/web-platform-tests/tools, but wiping the tools sub-directory never caused this library to be installed again.

The check to decide if the installation step should be skipped, it was only checking for the existence of the file defined at LayoutTests/imported/w3c/web-platform-tests/.tools.url rather than checking also for the target directory to exist.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170222/3470086c/attachment.html>