[Webkit-unassigned] [Bug 163159] [GTK] Crash attempting to load Flash plugin in Wayland

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163159

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #4) 
> No, it will never reach there, now that the bug is fixed.

As I said above, the UI process should be robust against the message being sent from a compromised or malfunctioning plugin process.

> > > Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:80
> > > +            if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland)
> > 
> > The check should be if type != X11, not if type == Wayland. I know that
> > makes the conditionals come out less-cleanly, but let's do it right.
> 
> Nope, I'm not sure if it's possible but if you build with wayland and X11
> disabled, you can't do that, because Type::X11 is not defined.

Then always return in that case.

But you don't even have to bother with that. You know PLATFORM(X11) is guaranteed inside ENABLE_PLUGIN_PROCESS_GTK2 or ENABLE_NETSCAPE_PLUGIN_API because both have dependencies on it:

# OptionsGTK.cmake
WEBKIT_OPTION_DEPEND(ENABLE_NETSCAPE_PLUGIN_API ENABLE_X11_TARGET)
WEBKIT_OPTION_DEPEND(ENABLE_PLUGIN_PROCESS_GTK2 ENABLE_X11_TARGET)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170222/6574c605/attachment.html>