[Webkit-unassigned] [Bug 162124] op_get_by_id_with_this should use inline caching

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 21 14:51:43 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=162124

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302034|review?                     |review+
              Flags|                            |

--- Comment #80 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 302034
  --> https://bugs.webkit.org/attachment.cgi?id=302034
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302034&action=review

r=me

> Source/JavaScriptCore/jit/Repatch.cpp:153
> +inline FunctionPtr appropriateGenericGetByIdFunction(GetByIDKind kind)
>  {
>      if (kind == GetByIDKind::Normal)
>          return operationGetById;
> +    else if (kind == GetByIDKind::WithThis)
> +        return operationGetByIdWithThisGeneric;
>      return operationTryGetById;
>  }

you also need to fill this out for appropriateOptimizingGetByIdFunction. That should probably lead to an insta crash if we ever got the wrong thing. At least, it should lead to noticeably not correct behavior. Please add a test for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170221/8c6b10fa/attachment.html>


More information about the webkit-unassigned mailing list