[Webkit-unassigned] [Bug 168570] [GTK] Test fast/events/message-port-postMessage-recursive.html times out

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168570

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #9)
> Comment on attachment 302252 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302252&action=review
> 
> > Source/WTF/wtf/glib/MainThreadGLib.cpp:38
> > +class MainThreadDispatcher {
> 
> Please add a comment. You could take it from your commit message.

Ok.

> > Source/WTF/wtf/glib/MainThreadGLib.cpp:43
> > +        m_timer.setPriority(G_PRIORITY_HIGH_IDLE + 20);
> 
> Too fragile. It has to be exactly equal to WebCore timers? Then you should
> fine some common header to define it in.

Not really, I'm just conservative here and using at least the same priority. I still think we should re-think all the timer priorities anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170221/ceeef864/attachment.html>