[Webkit-unassigned] [Bug 166681] WebInspector: refactor RemoteInspector to move cocoa specific code to their own files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 15 23:39:26 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=166681

--- Comment #28 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 298557
  --> https://bugs.webkit.org/attachment.cgi?id=298557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298557&action=review

> Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mmSource/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.mm:213
> -void RemoteConnectionToTarget::sendMessageToTarget(NSString *message)
> +void RemoteConnectionToTarget::sendMessageToTarget(const String& message)

This change broke it.  I'm going to re-commit it with an NSString.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170216/12d31bee/attachment.html>


More information about the webkit-unassigned mailing list