[Webkit-unassigned] [Bug 168350] JSC: missing implementations of MacroAssemblerMIPS::load8SignedExtendTo32()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168350

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301574|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #5 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 301574
  --> https://bugs.webkit.org/attachment.cgi?id=301574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301574&action=review

r=me with a fix.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:764
> +    }

Looks good.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:796
> +        load8(address.m_ptr, dest);

Why is it OK? I think we should use load8SignedExtendTo32 here (and delegate to `void load8SignedExtendTo32(const void* address, RegisterID dest)`), correct?

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:806
> +        m_assembler.lb(dest, addrTempRegister, 0);

OK. The difference from load8 is using lb instead of lbu.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170215/76ceb100/attachment.html>