[Webkit-unassigned] [Bug 168229] CookieManager only works with the default session

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168229

--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #16)
> (In reply to comment #15)
> > (In reply to comment #11)
> > > (In reply to comment #5)
> > > > Comment on attachment 301344 [details]
> > > > Patch
> > > > 
> > > > I like the direction this code is going in.  Definitely fix the Windows
> > > > build.  WTF::Functions are not copyable, and that seems preferable in this
> > > > case.  Can this be tested?
> > > 
> > > I started using Function but had to change it to std::function to be able to
> > > use it in HashMap value.
> > 
> > Nothing about a Function precludes it from being a HashMap value; We use
> > Functions in HashMap values all the time.
> 
> For hints, search WebKit2 for:
> `HashMap<uint64_t, Function`

I did it when I found the issue, and all those were cases where function is added once and then taken, like completion handlers. In that case there's no problem because take doesn't need to copy, it just moves. Here we need to set once and get multiple times. We could take and set on every get, but I don't think it's worth it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170215/7a3ce386/attachment.html>