[Webkit-unassigned] [Bug 168304] New: Use a set instead of a list for tests when parsing expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 14 04:49:19 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=168304

            Bug ID: 168304
           Summary: Use a set instead of a list for tests when parsing
                    expectations
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: webkit.org at the-compiler.org
                CC: lforschler at apple.com

In _collect_matching_tests, a lot of membership tests are done on a giant list of strings. By making it a set instead, we can make those much faster, and there's no reason for it to be a list.

With ~45k tests and some 1000 expectations, this reduces the parse time from 34s to 3s on my machine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170214/84be53a1/attachment.html>


More information about the webkit-unassigned mailing list