[Webkit-unassigned] [Bug 168229] CookieManager only works with the default session

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168229

--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 301344 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301344&action=review
> 
> Nice work! I trust you'll find an owner to review it.
> 
> Any reason you used std::function instead of the preferred WTF::Function?

Because a non copyable function can't be used as a value of a HashMap.

> > Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:46
> > +    static NeverDestroyed<HashMap<CFHTTPCookieStorageRef, std::function<void ()>>> map;
> 
> You need to fix Windows:
> 
> C:
> \cygwin\home\buildbot\WebKit\Source\WebCore\platform\network\cf\CookieStorage
> CFNet.cpp(46): error C2079: 'map' uses undefined class
> 'WTF::NeverDestroyed<WTF::HashMap<CFHTTPCookieStorageRef,std::function<void
> (void)>,WTF::PtrHash<P
> *>,WTF::HashTraits<KeyArg>,WTF::HashTraits<MappedArg>>>'
> [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.
> vcxproj]
>           with
>           [
>               P=OpaqueCFHTTPCookieStorage,
>               KeyArg=CFHTTPCookieStorageRef,
>               MappedArg=std::function<void (void)>
>           ]
> 
> Probably a missing #include?

Yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170214/ac68af1e/attachment.html>