[Webkit-unassigned] [Bug 162458] EWS should run JavaScriptCore tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162458

--- Comment #46 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 301437
  --> https://bugs.webkit.org/attachment.cgi?id=301437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301437&action=review

> Tools/QueueStatusServer/model/queuestatus.py:46
> +        return self.message.startswith(messages.skip_status)

I just noticed that this disagrees with what I wrote in my second remark in comment 42, which implemented this function using a strict string comparision. Unless the EWS code does not emit skip_status (what does it emit when AbstractPatchQueue.did_fail() is invoked?) when skipping a patch by default, I do not feel there is value in having the EWS code (in webkitpy) emits a message of the form "Patch not applicable to %s."

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170214/2ec80091/attachment.html>