[Webkit-unassigned] [Bug 168128] [GTK] Non-accelerated drawing is broken with HiDPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 13 01:29:43 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=168128

--- Comment #17 from Adrian Perez <aperez at igalia.com> ---
(In reply to comment #15)
> This has nothing to do with DRI3, the only problem is the device scale
> factor.

Right, I forgot to mention that my old laptop, apart from having DRI3
disabled, does _not_ have a HiDPI screen. 

I built WebKitGTK+ locally with your patch applied, and I can confirm
that MiniBrowser correctly paints websites now, both using 1x and 2x
scale-factor. Tested with all the combinations of environment variables:

  % run-minibrowser --gtk --debug   # No environment varible.
  % WEBKIT_DISABLE_COMPOSITING_MODE=1 run-minibrowser --gtk --debug
  % WEBKIT_FORCE_COMPOSITING_MODE=1 run-minibrowser --gtk --debug

So informal r+ from me — now that I see what it does, it makes sense.

                                - - - - -

Side question: is there some way in which we could avoid this kind of
regression in the future? It would be interesting to do some automated
smoketesting, like building and loading a few selected websites with
MiniBrowser under the control of a script, capturing the screen, and
checking that there are non-blank pixels on a capture of the window, for
different scale-factors and AC/non-AC modes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170213/aacc6338/attachment.html>


More information about the webkit-unassigned mailing list