[Webkit-unassigned] [Bug 168193] New: REGRESSION(r212192): [GTK] Broke downloads API tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 12 11:08:02 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=168193

            Bug ID: 168193
           Summary: REGRESSION(r212192): [GTK] Broke downloads API tests
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org

Implementing MIMETypeRegistry::getPreferredExtensionForMIMEType in r212192 broke our downloads API test:

TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads... (pid=31826)

  /webkit2/Downloads/local-file:                                       OK

  /webkit2/Downloads/overwrite-destination-allowed:                    OK

  /webkit2/Downloads/overwrite-destination-disallowed:                 OK

  /webkit2/Downloads/local-file-error:                                 OK

  /webkit2/Downloads/remote-file:                                      **

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:186:void DownloadTest::checkDestinationAndDeleteFile(WebKitDownload*, const char*): assertion failed (destBasename.get() == expectedName): ("webkit-downloaded-file.pdf" == "webkit-downloaded-file")

FAIL

I guess it's now expected that the .pdf file extension be added even though it's not included in the server suggested filename, so the change was correct and the test should be updated, right? It seems a bit odd that we would add the file extension on the client side, but I guess that's the expected behavior?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170212/a4b62324/attachment.html>


More information about the webkit-unassigned mailing list