[Webkit-unassigned] [Bug 168183] [Cocoa] Some -respondsToSelector: checks are unnecessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 12 00:11:36 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=168183

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org

--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 301293 did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4166:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4166:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4167:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4167:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4172:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4167:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4167:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4172:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/WebKit2/Platform/spi/ios/UIKitSPI.h:311:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebKit2/Platform/spi/ios/UIKitSPI.h:311:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:489:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:489:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:490:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:490:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:495:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:497:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:490:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:490:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:495:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:497:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
Total errors found: 20 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170212/6cd17d30/attachment.html>


More information about the webkit-unassigned mailing list