[Webkit-unassigned] [Bug 165561] WebCore::Pasteboard Two separate functions would be clearer than one function with an argument.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 11 20:09:37 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=165561

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301115|review?                     |review+
              Flags|                            |

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 301115
  --> https://bugs.webkit.org/attachment.cgi?id=301115
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301115&action=review

Thanks for working on refactorings!

I think I would name this function "writePlainTextWithSmartReplace".

When you upload your next patch, be sure to set the cq? Bugzilla flag to request the patch be committed.

> Source/WebCore/ChangeLog:4
> +        Created a second function that handle smart replaceing
> +        and edited the original one to handle regular replacing only.

Again, this should be the title of the bug. Your explanation is good, but move it down below, between the "Reviewed by" line and the "No new tests" line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170212/cecfbca5/attachment.html>


More information about the webkit-unassigned mailing list