[Webkit-unassigned] [Bug 168015] [GStreamer][MSE] Some GStreamer log messages are generated with the 'default' category

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 10 12:27:22 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=168015

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301178|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 301178
  --> https://bugs.webkit.org/attachment.cgi?id=301178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301178&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:27
> +#include <gst/gst.h>

This include does not seem to be needed, please confirm it and remove it.

> Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:59
> +#define WEBKIT_MEDIA_SRC_CATEGORY_INIT GST_DEBUG_CATEGORY_INIT(webkit_media_src_debug, "webkitmediasrc", 0, "websrc element");

Taking advantage of having to remove the include above and having to upload the patch again, let's change:

"websrc element" -> "web media source element"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170210/4c2d47b1/attachment.html>


More information about the webkit-unassigned mailing list