[Webkit-unassigned] [Bug 163208] [ES6]. Implement Annex B.3.3 function hoisting rules for eval

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163208

--- Comment #36 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 301063
  --> https://bugs.webkit.org/attachment.cgi?id=301063
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301063&action=review

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:833
> +    if (JSScope* scope = jsDynamicCast<JSScope*>(exec->vm(), object)) {

You already have a VM available here, no need to exec->vm().

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:837
> +            result = ((JSCell*)object)->isObject();

This should always be true.

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:839
> +        result = ((JSCell*)object)->isObject();

This should always be true. If it resolved to a with scope, with scopes can only be over objects, I think. It's worth verifying I'm correct. I suspect `with(foo) { ... }` will always toObject the `foo`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170209/12d0b6e3/attachment.html>