[Webkit-unassigned] [Bug 168015] [GStreamer][MSE] Some GStreamer log messages are generated with the 'default' category
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 9 01:18:15 PST 2017
https://bugs.webkit.org/show_bug.cgi?id=168015
Xabier RodrÃguez Calvar <calvaris at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #300961|review? |review-
Flags| |
--- Comment #5 from Xabier RodrÃguez Calvar <calvaris at igalia.com> ---
Comment on attachment 300961
--> https://bugs.webkit.org/attachment.cgi?id=300961
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=300961&action=review
Though some stuff needs some polishing, good patch!
> Source/WebCore/ChangeLog:14
> + (WebCore::AppendPipeline::AppendPipeline): Initialize the Gstreamer logging category
It should be written as GStreamer
> Source/WebCore/ChangeLog:19
> + (WebCore::PlaybackPipeline::PlaybackPipeline): Initialize the Gstreamer logging category
Ditto.
> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:45
> +GST_DEBUG_CATEGORY(webkit_appendpipeline_debug);
> +#define GST_CAT_DEFAULT webkit_appendpipeline_debug
Please use webkit_mse_debug, that is defined in MediaPlayerPrivateGStreamerMSE.cpp. For this you will need to make the declaration in MediaPlayerPrivateGStreamerMSE.cpp as _EXTERN as it is done for GStreamer and GStreamerBase.
> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:122
> + GST_DEBUG_CATEGORY_INIT(webkit_appendpipeline_debug, "webkitmse", 0, "WebKit MSE media player");
As you will be using an already initialized category you won't need this and it can be removed.
> Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:30
> +#include <gst/gstinfo.h>
> +
> +GST_DEBUG_CATEGORY(webkit_mse_client_debug);
> +#define GST_CAT_DEFAULT webkit_mse_client_debug
Same here as for AppendPipeline. Check if the include is needed if you remove the initialization below.
> Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:51
> + GST_DEBUG_CATEGORY_INIT(webkit_mse_client_debug, "webkitmse", 0, "WebKit MSE media player");
Remove this.
> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:44
> +GST_DEBUG_CATEGORY(webkit_playbackpipeline_debug);
> +#define GST_CAT_DEFAULT webkit_playbackpipeline_debug
Same here.
> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:98
> +PlaybackPipeline::PlaybackPipeline()
> +{
> + GST_DEBUG_CATEGORY_INIT(webkit_playbackpipeline_debug, "webkitmse", 0, "WebKit MSE media player");
> +}
> +
You don't need this.
> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.h:73
> - PlaybackPipeline() = default;
> + PlaybackPipeline();
You don't need this.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170209/d934c6bb/attachment.html>
More information about the webkit-unassigned
mailing list