[Webkit-unassigned] [Bug 168008] New: Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 8 11:36:47 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=168008

            Bug ID: 168008
           Summary: Audit WebCore uses of RunLoop::main for
                    USE(WEB_THREAD) iOS WebKit1
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: joepeck at webkit.org
                CC: andersca at apple.com, ap at webkit.org,
                    ddkilzer at webkit.org, joepeck at webkit.org

Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1

Seems like these would need to handle iOS WebKit's WebThread.

    bindings/js/SerializedScriptValue.cpp
    2912:    RunLoop::main().dispatch([this, conditionPtr = &condition, valuePtr = &value] {

    inspector/WebHeapAgent.cpp
    57:    , m_timer(RunLoop::main(), this, &SendGarbageCollectionEventsTask::timerFired)

    Modules/applepay/ApplePaySession.cpp
    496:        RunLoop::main().dispatch([promise, canMakePayments]() mutable {

    Modules/websockets/WebSocket.cpp
    295:            RunLoop::main().dispatch([this, protectedThis = makeRef(*this)]() {

    platform/graphics/MediaPlaybackTargetPicker.cpp
    40:    , m_pendingActionTimer(RunLoop::main(), this, &MediaPlaybackTargetPicker::pendingActionTimerFired)

    workers/WorkerMessagingProxy.cpp
    165:    RunLoop::main().dispatch([this, message = message.isolatedCopy()] {

This is code in WebCore that stays in WebCore, so probably needs a WebThreadLock for legacy WebKit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170208/ee7e56c4/attachment-0001.html>


More information about the webkit-unassigned mailing list