[Webkit-unassigned] [Bug 167950] New: SigillCrashAnalyzer::analyze() use a do-while loop instead of a lambda.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167950

            Bug ID: 167950
           Summary: SigillCrashAnalyzer::analyze() use a do-while loop
                    instead of a lambda.
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

Michael pointed out to me that lambda's aren't free, and suggested I use a do-while loop instead.  I didn't think to use a loop when I first wrote this code (brain malfunction), but had reasoned that the compiler should be able to realize that the lambda does not escape, and hence can be inlined complete.  However, a quick disassembly of the compiled code reveals that this is not the case: the compiler did not inline the lambda.  Even though this code is not in a performance critical path, I'll switch the code to using a do-while loop just so it doesn't encourage uses of lambda (like this) where not needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170207/a8622374/attachment-0001.html>