[Webkit-unassigned] [Bug 167876] [Soup] Deadlock in NetworkProcess

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167876

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> According to myself in https://bugs.webkit.org/show_bug.cgi?id=85880#c9 the
> mutex is needed, because glib will use a thread to implement read_async, and
> webkitSoupRequestInputStreamAddData can be called from other thread. Before
> r210374, that thread was the message work queue, that's why this never
> happened. Now it's the main thread, so I guess we just need to release the
> lock.

But I was wrong, because we are overriding GInputStreamClass::read_async, claiming we know how to handle the async request, and therefore not using the fallback implementation in GInputStream that runs the thread. It makes sense, indeed, because we are actually a GMemoryInputStream, there's no io in the read function, so we can handle it in the main thread.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170206/8375e8d7/attachment.html>