[Webkit-unassigned] [Bug 167838] Fix memory issues related to preload eviction.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167838

Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #300634|review?                     |review+
              Flags|                            |

--- Comment #3 from Andreas Kling <akling at apple.com> ---
Comment on attachment 300634
  --> https://bugs.webkit.org/attachment.cgi?id=300634
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300634&action=review

r=me, thanks for the quick turnaround :)

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:1274
> +    if (linkPreloads && linkPreloads->size())
> +        m_preloads = WTFMove(linkPreloads);
> +    else
>          m_preloads = nullptr;

I think linkPreloads->size() is guaranteed to be >= 1 here, since you only allocate it when actually adding something.
I would suggest renaming it to remainingLinkPreloads, and then replacing this block with simply:
m_preloads = WTFMove(remainingLinkPreloads);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170204/96ed9138/attachment.html>