[Webkit-unassigned] [Bug 163897] [CMake] RelWithDebInfo builds are super broken at runtime

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 08:27:12 PST 2017


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #300514|review?                     |review+
              Flags|                            |

--- Comment #15 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 300514
  --> https://bugs.webkit.org/attachment.cgi?id=300514
annulen's patch

r=me because this is clearly better than what we're doing now.

I'm a bit concerned that we're adding our flags after ${CMAKE_C_FLAGS} rather than before. That is, we're overriding the CFLAGS and CXXFLAGS set by the user. That's generally considered to be bad form in Autotools projects, where the user is always supposed to be override our build flags. But maybe it's better that we don't give the user control over these particular flags. E.g. Linux distros use -fexceptions in order to get better backtraces, but that's really mostly intended for C projects, not C++ projects that don't use exceptions; I imagine it could lead to significant code size bloat in WebKit for insufficient benefit, and that change would be immediately noticed if we were to change this. So I dunno.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170203/c2cbfca7/attachment-0001.html>

More information about the webkit-unassigned mailing list