[Webkit-unassigned] [Bug 167785] New: JSDOMWindowBase.cpp doesn't build if the JIT is disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 3 01:47:06 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=167785

            Bug ID: 167785
           Summary: JSDOMWindowBase.cpp doesn't build if the JIT is
                    disabled
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: berto at igalia.com

r211403 moved GetCallerGlobalObjectFunctor from JSDOMBinding.cpp to JSDOMWindowBase.cpp, but forgot to include bytecode/CodeBlock.h in the latter file.

This breaks the build if the JIT is disabled because the headers that would include ClodeBlock.h indirectly are guarded by ENABLE(JIT).

Reproduced with WebKitGTK+ 2.15.4:

Source/WebCore/bindings/js/JSDOMWindowBase.cpp: In member function 'JSC::StackVisitor::Status WebCore::callerDOMWindow(JSC::ExecState*)::GetCallerGlobalObjectFunctor::operator()(JSC::StackVisitor&) const':
Source/WebCore/bindings/js/JSDOMWindowBase.cpp:304:43: error: invalid use of incomplete type 'class JSC::CodeBlock'
                 m_globalObject = codeBlock->globalObject();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170203/45110378/attachment.html>


More information about the webkit-unassigned mailing list