[Webkit-unassigned] [Bug 181158] New: Horizontal margins are not collapsed for children of <mrow>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181158

            Bug ID: 181158
           Summary: Horizontal margins are not collapsed for children of
                    <mrow>
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: MathML
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: lambda at liu.ms

Created attachment 330190

  --> https://bugs.webkit.org/attachment.cgi?id=330190&action=review

Horizontal margins are not collapsed for children of <mrow>

See the attachment for an example.

The reason comes to the following code:

RenderMathMLRow::layoutRowItems

for (auto* child = firstChildBox(); child; child = child->nextSiblingBox()) {
    // ...
    horizontalOffset += child->marginStart();
    // ...
    horizontalOffset += childWidth + child->marginEnd();
}

RenderMathMLRow::getContentBoundingBox

for (auto* child = firstChildBox(); child; child = child->nextSiblingBox()) {
    // ...
    width += child->marginStart() + child->logicalWidth() + child->marginEnd();
    // ...
}

I think we should really ignores margin/padding/border for MathML elements. It appears that Firefox does that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171226/da57122d/attachment.html>