[Webkit-unassigned] [Bug 181136] New: ResourceLoadStatisticsPersistentStorage is broken in ephemeral sessions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 22 14:07:17 PST 2017


            Bug ID: 181136
           Summary: ResourceLoadStatisticsPersistentStorage is broken in
                    ephemeral sessions
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bfulgham at webkit.org, bugs-noreply at webkitgtk.org,
                    cdumez at apple.com, wilander at apple.com

GTK API test /webkit2/WebKitWebsiteData/ephemeral is broken:

ASSERTION FAILED: !storagePath.isEmpty()
../../Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp(147) : void WebKit::ResourceLoadStatisticsPersistentStorage::monitorDirectoryForNewStatistics()

Looks like this probably regressed in r219530 "Monitor directory for new statistics files after a delete operation" and we just didn't notice until now. Problem is WebResourceLoadStatisticsStore creates a ResourceLoadStatisticsPersistentStorage object unconditionally. ResourceLoadStatisticsPersistentStorage asserts that storagePath is not empty, but it's intentionally empty in ephemeral mode.

The proper fix is not obvious to me, but perhaps teaching WebResourceLoadStatisticsStore to not create a ResourceLoadStatisticsPersistentStorage in this case makes more sense than teaching ResourceLoadStatisticsPersistentStorage to be not persistent.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171222/f611a279/attachment.html>

More information about the webkit-unassigned mailing list