[Webkit-unassigned] [Bug 180923] [Followup to 179682] Add comment and code style improvement to MUnderOver's layout functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 20 17:01:18 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=180923

--- Comment #9 from Minsheng Liu <lambda at liu.ms> ---
You are correct. It strikes me that we do not have a test case for this. I will add one.

(In reply to Frédéric Wang (:fredw) [back 03/01/2018] from comment #7)
> Comment on attachment 329737 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329737&action=review
> 
> For some reason I did not receive the bug spam for this, sorry for the delay.
> 
> > Source/WebCore/ChangeLog:3
> > +        [Followup to 179682] Add comment and code style improvement to MUnderOver's layout functions
> 
> I think you should use bug number 180923 and explain below that it is a
> follow-up.
> It's either munderover (tag name) or RenderMathMLUnderOver (class name).
> 
> > Source/WebCore/ChangeLog:14
> > +        It makes unembellishedOperator() a const function.
> 
> If this one is trickier, it should probably be a separate bug. Let's not
> delay the missing bits. Actually there is probably already a bug report for
> that...
> 
> > Source/WebCore/ChangeLog:16
> > +        It also provide comments for stretchHorizontalOperatorsAndLayoutChildren() and elinminates
> 
> eliminate
> 
> > Source/WebCore/ChangeLog:19
> > +        There is no behavior change so no new tests are necessary.
> 
> See my comment below about fixLayoutAfterStretch.
> 
> > Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:-87
> > -            fixLayoutAfterStretch(child, stretchyOperator);
> 
> If you remove this and don't do it again in the isAllStretchyOperators
> conditional below, then it's actually a behavior change.
> 
> > Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:113
> >          for (auto* embellishedOperator : embellishedOperators)
> 
> I think you'll need to do a for (size_t i = 0; i <
> embellishedOperators.size(); i++) in order to call fixLayoutAfterStretch and
> ensure that embellishedOperator->logicalWidth() is correctly set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171221/469d8b09/attachment-0001.html>


More information about the webkit-unassigned mailing list