[Webkit-unassigned] [Bug 180528] Update HSL/HSLA parsing to match CSS Color 4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180528

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329855|1                           |0
        is obsolete|                            |

--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 329855
  --> https://bugs.webkit.org/attachment.cgi?id=329855
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329855&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

It needs some, obviously. Look in LayoutTests/fast/css/.... for examples.

> Source/WebCore/platform/graphics/Color.cpp:108
> +        hueVal += 6.0;
> +    else if (hueVal >= 6.0)
> +        hueVal -= 6.0;
> +    if (hueVal < 1.0)
> +        return temp1 + (temp2 - temp1) * hueVal;
> +    if (hueVal < 3.0)

So is this changing how we compute hue? That's a little surprising.

> Tools/Scripts/webkitpy/common/checkout/scm/detection.py:6
> +# Copyright (c) 2009, 2010, 2011 Google Inc. All rights reserved.
> +# Copyright (c) 2009 Apple Inc. All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions are
> +# met:

I guess you nuked the line endings on this file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171220/c335d4f5/attachment-0001.html>