[Webkit-unassigned] [Bug 180928] [EME] Add layout test for clearKey CENC message event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 19 01:21:01 PST 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #329651|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 329651
  --> https://bugs.webkit.org/attachment.cgi?id=329651

The test looks mainly ok and it does not deserve an r- but I think we can improve it, specially thinking of the future, if any.

I see two things. First, I'd prefer to use const and let instead of var.

Second, this cenc message test should be enough already, but I am not going to complain only for one test. If you're planning to file more dual tests like this that are mostly the same (almost everything but the video and test initialization is the same) we should think of a common way of running these tests. My suggestion would be merging both tests at least to share the biggest part of the code and maybe thinking of a way of writing a small utility to run the same code through MSE and non-MSE paths if only initialization is different).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171219/8fcab6b0/attachment.html>

More information about the webkit-unassigned mailing list