[Webkit-unassigned] [Bug 180923] [Followup to 179682] Add comment and code style improvement to MUnderOver's layout functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 18 20:56:25 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=180923

--- Comment #5 from Minsheng Liu <lambda at liu.ms> ---
I have removed "to" in the function's name as suggested by Darin.

Also, @zalan pointed out in 179682 that unembellishedOperator() should be const. I forgot to deal with that in my last patch but handled it in the new one. The only tricky part is that I had to use a const_cast because for RenderMathMLOperator, unembellishedOperator() needs to return *this, which is a pointer to a const object. I think this usage aligns with how we deal with other getters such as firstChild(), but I am not an expert on C++ so I need some professional advice on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171219/e757e41b/attachment-0001.html>


More information about the webkit-unassigned mailing list