[Webkit-unassigned] [Bug 180914] New: fix build with -DENABLE_OPENGL=OFF: add missing ENABLE_WEBGL conditionals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180914

            Bug ID: 180914
           Summary: fix build with -DENABLE_OPENGL=OFF: add missing
                    ENABLE_WEBGL conditionals
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: enometh at meer.net

Building webkitgtk-2.19.3 fails with cmake -DENABLE_OPENGL=OFF fails
on certain files.  Apparently because the code is not enclosed in #if
ENABLE(WEBGL) .. #endif blocks as expected.

* Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h
* Source/WebCore/html/canvas/WebGLContextGroup.h
Eg.
     In file included from ../Source/WebCore/html/canvas/WebGLContextGroup.cpp:27:0,
       from DerivedSources/WebCore/unified-sources/UnifiedSource252.cpp:2:
    ../Source/WebCore/html/canvas/WebGLContextGroup.h:37:21: error: 'WebGLRenderingContextBase' has not been declared
         void addContext(WebGLRenderingContextBase&);
                         ^~~~~~~~~~~~~~~~~~~~~~~~~

* Source/WebCore/html/canvas/WebGLExtension.{h,cpp}:

    In file included from ../Source/WebCore/html/canvas/OESVertexArrayObject.h:29:0,
                     from ../Source/WebCore/html/canvas/OESVertexArrayObject.cpp:27,
                     from DerivedSources/WebCore/unified-sources/UnifiedSource250.cpp:8:
    ../Source/WebCore/html/canvas/WebGLExtension.h: In member function 'void WebCore::WebGLExtension::ref()':
    ../Source/WebCore/html/canvas/WebGLExtension.h:60:27: error: invalid use of incomplete type 'class WebCore::WebGLRenderingContextBase'
         void ref() { m_context.ref(); }
                ^

The attached patch outlining those fixes is against webkitgtk-2.19.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171217/60ec87e3/attachment.html>