[Webkit-unassigned] [Bug 180913] New: fix compilation failures for a Release build with assertions turned on

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 17 07:18:28 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=180913

            Bug ID: 180913
           Summary: fix compilation failures for a Release build with
                    assertions turned on
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: enometh at meer.net

Created attachment 329602

  --> https://bugs.webkit.org/attachment.cgi?id=329602&action=review

fix NDEBUG conditionals for a Release build with assertions turned on

A Release build (-DNDEBUG) with assertions turned on     
(i.e. -DASSERT_DISABLED=0 -DASSERT_MSG_DISABLED=0 etc. see Source/WTF/wtf/Assertions.h) currently fails at various places. 

These failures typically stem from the use of variables in ASSERTS where
the variable itself was defined inside an #ifndef NDEBUG ... #endif block.
The failures can be fixed by putting the asserts within #ifndef NDEBUG ..#endif blocks.  (And there are a few cases where the blocks seem to be conditionalized on ASSERT_DISABLED instead of NDEBUG)


Attached is a patch against webkitgtk-2.19.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171217/3f97579c/attachment-0001.html>


More information about the webkit-unassigned mailing list