[Webkit-unassigned] [Bug 180861] [GTK][WPE] Enable WebProcess memory monitor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180861

--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Carlos Alberto Lopez Perez from comment #4)

> Instead of making this configurable, we can have a dynamic thresold that
> depends on the amount of RAM of the device. A simple rule may be:
> 
> 
> baseThresholdForPolicy == std::min(3 * GB, totalSystemRAM)
> 
> switch (policy) {
>      case MemoryUsagePolicy::Conservative:
>          return baseThresholdForPolicy / 2;
                                    ^ 3
>      case MemoryUsagePolicy::Strict:
>  	return baseThresholdForPolicy / 3;
                                    ^  2
>      case MemoryUsagePolicy::Unrestricted:
>      default:
>          ASSERT_NOT_REACHED();
>          return 0;
> }
> 

Ups, I got confused with the values above. The 2 and the 3 should be exchanged.

@@ -2,9 +2,9 @@

 switch (policy) {
      case MemoryUsagePolicy::Conservative:
-         return baseThresholdForPolicy / 2;
+         return baseThresholdForPolicy / 3;
      case MemoryUsagePolicy::Strict:
-       return baseThresholdForPolicy / 3;
+       return baseThresholdForPolicy / 2;
      case MemoryUsagePolicy::Unrestricted:
      default:
          ASSERT_NOT_REACHED();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171216/f763a8b7/attachment.html>