[Webkit-unassigned] [Bug 180862] [GTK][WPE] Add WebKitWebView::web-process-terminated signal and deprecate web-process-crashed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180862

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329484|review?                     |review+
              Flags|                            |

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 329484
  --> https://bugs.webkit.org/attachment.cgi?id=329484
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329484&action=review

I thought about recommending that we adjust the API for the possibility that, in the future, we might want to notify the UI process if other secondary processes terminate. The signal could be SECONDARY_PROCESS_TERMINATED or just PROCESS_TERMINATED instead of WEB_PROCESS_TERMINATED.

But I doubt we'll ever need to do that, and this seems clearer.

> Source/WebKit/UIProcess/API/gtk/WebKitWebView.h:191
> + * @WEBKIT_WEB_PROCESS_CRAHED: the web process crashed.

CRASHED

> Source/WebKit/UIProcess/API/wpe/WebKitWebView.h:166
> +    WEBKIT_WEB_PROCESS_CRAHED,

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:86
> +    g_assert_cmpuint(reason, ==, WEBKIT_WEB_PROCESS_CRAHED);

You have to look after you Ctrl+V :P

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171215/dd084a75/attachment.html>