[Webkit-unassigned] [Bug 180513] [Touch Bar Web API] Add support for custom Touch Bar buttons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180513

--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 329366
  --> https://bugs.webkit.org/attachment.cgi?id=329366
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329366&action=review

> Source/WebKit/Shared/WebPreferences.yaml:644
> +  defaultValue: true

I don't think we'll want to enable <menuitem> by default quite yet!

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:667
> +- (nullable NSTouchBarItem *)itemForIdentifier:(NSString *)identifier

Hm...is overriding -itemForIdentifier: here needed? The idea is that AppKit internally maintains a cache of touch bar items, and the superclass (NSTouchBar's) implementation of -itemForIdentifier: either returns a cached touch bar item (if any is found) or, if necessary, invokes -makeItemForIdentifier: to create a new touch bar item (which it then adds to the item cache).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171214/5eeca972/attachment.html>