[Webkit-unassigned] [Bug 180552] [WK2] Expose image via WKBundleHitTestResult API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180552

--- Comment #15 from Zach Li <zacharyli323 at gmail.com> ---
(In reply to Simon Fraser (smfr) from comment #13)
> Comment on attachment 329133 [details]
> Patch v3
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329133&action=review
> 
> > Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:185
> > +    BitmapImage& bitmapImage = downcast<BitmapImage>(*image);
> > +    IntSize size(bitmapImage.size());
> > +    auto webImage = WebImage::create(size, static_cast<ImageOptions>(0));
> > +
> > +    auto graphicsContext = webImage->bitmap().createGraphicsContext();
> > +    graphicsContext->drawImage(bitmapImage, {{ }, size});
> 
> This needs a FIXME comment saying something like "FIXME: need to handle EXIF
> rotation".

Done in the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171212/b54b9258/attachment.html>