[Webkit-unassigned] [Bug 180552] [WK2] Expose image via WKBundleHitTestResult API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 12 11:55:24 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=180552

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329133|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 329133
  --> https://bugs.webkit.org/attachment.cgi?id=329133
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=329133&action=review

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:185
> +    BitmapImage& bitmapImage = downcast<BitmapImage>(*image);
> +    IntSize size(bitmapImage.size());
> +    auto webImage = WebImage::create(size, static_cast<ImageOptions>(0));
> +
> +    auto graphicsContext = webImage->bitmap().createGraphicsContext();
> +    graphicsContext->drawImage(bitmapImage, {{ }, size});

This needs a FIXME comment saying something like "FIXME: need to handle EXIF rotation".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171212/7a228b52/attachment.html>


More information about the webkit-unassigned mailing list