[Webkit-unassigned] [Bug 180691] Symbol not found: __ZN3WTF8LockBase10unlockSlowEv

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180691

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329096|review?                     |review+
              Flags|                            |

--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 329096
  --> https://bugs.webkit.org/attachment.cgi?id=329096
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=329096&action=review

>> Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:132
>> +#if PLATFORM(MAC)
> 
> Not sure if it is worth adding a restriction here, such as:
> 
>     && __MAC_OS_X_VERSION_MIN_REQUIRED < 101340
> 
> But reviewers let me know if you think that would be worth doing.

I think this restriction is useful since it can be a marker for dropping this in the future.
Adding `FIXME` comment is also nice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171212/038d1e09/attachment.html>