[Webkit-unassigned] [Bug 180513] [Touch Bar Web API] Add support for custom Touch Bar buttons

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 11 09:34:48 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=180513

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 328668
  --> https://bugs.webkit.org/attachment.cgi?id=328668
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328668&action=review

> Source/WebKit/UIProcess/mac/PageClientImplMac.h:107
> +    void touchBarMenuDataDidChange() override;

To get this compiling on iOS either:

1) We need a line like this in the iOS version in PageClientImplIOS.h, or
2) We need the function in the base class to not be pure virtual, or
3) We need to put it more of the code in a HAVE(TOUCH_BAR) or PLATFORM(MAC) conditional instead of PLATFORM(COCOA).

Or something else like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171211/00cb2be2/attachment.html>


More information about the webkit-unassigned mailing list