[Webkit-unassigned] [Bug 180539] ApplicationManifestParser should strip whitespace from the raw input

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 8 16:49:57 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=180539

--- Comment #14 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 328837
  --> https://bugs.webkit.org/attachment.cgi?id=328837
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=328837&action=review

> Source/WTF/wtf/JSONValues.cpp:545
> -    if (!result || tokenEnd != end)
> +    if (!result)
>          return false;
>  
> +    for (const UChar* valueEnd = tokenEnd; valueEnd < end; ++valueEnd) {
> +        if (!isSpaceOrNewline(*valueEnd))
> +            return false;
> +    }

Where is the ChangeLog for these changes? Also, a change like this needs a layout test validated against the spec and other browsers, not an API test.

> Source/WebCore/ChangeLog:10
> +        * Modules/applicationmanifest/ApplicationManifestParser.cpp:
> +        (WebCore::ApplicationManifestParser::parseManifest):

This change is not in the patch, and was not committed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171209/e2757697/attachment.html>


More information about the webkit-unassigned mailing list