[Webkit-unassigned] [Bug 180552] [WK2] Expose image via WKBundleHitTestResult API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180552

--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
(In reply to Zach Li from comment #8)
> (In reply to Simon Fraser (smfr) from comment #7)
> > Comment on attachment 328872 [details]
> > Patch v2
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=328872&action=review
> > 
> > > Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:185
> > > +    graphicsContext->drawImage(bitmapImage, {{ }, sizeRespectingOrientation});
> > 
> > Does this do the correct thing for images with EXIF rotations?
> 
> I took a look at -drawImage() function and by default,
> DoNotRespectImageOrientation is passed to ImagePaintingOptions, so this
> means it would not auto-rotate images with EXIF orientation tags? (Sorry, I
> am not so familiar with this area of code)
> 
> But at least for my use case, image orientation does not matter.

But if the image is rotated, you'll get an image with the wrong dimensions, and squished. So I think you have to care. Did you test it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171209/4223e10f/attachment-0001.html>