[Webkit-unassigned] [Bug 180562] Turn on ENABLE_APPLICATION_MANIFEST on iOS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 8 11:28:36 PST 2017


--- Comment #7 from David Quesada <david_quesada at apple.com> ---
(In reply to Sam Weinig from comment #5)
> What makes this feature iOS only? In general, we would like everything to be
> enable on all supported platforms.

(In reply to Brady Eidson from comment #6)
> Comment on attachment 328817 [details]
> Patch v3
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328817&action=review
> > LayoutTests/platform/ios/TestExpectations:24
> > +http/tests/security/contentSecurityPolicy/manifest-src-allowed.html [ Pass ]
> > +http/tests/security/contentSecurityPolicy/manifest-src-blocked.html [ Pass ]
> > +applicationmanifest/ [ Pass ]
> Why explicit PASSes? Where are they otherwise skipped?

They're skipped in LayoutTests/TestExpectations, since the feature was disabled while I was landing all the pieces.

> > Source/WebCore/loader/cache/CachedResourceRequest.cpp:39
> > +#include "ServiceWorkerRegistrationData.h"
> This can't be a necessary part of your patch

Do you mean I can't include this line in this patch, or you don't see why this line is needed? Before enabling the flag, CachedResourceRequest.cpp implicitly depended on having this header included by another file in the unified sources. When the feature is enabled and additional files are included in the unified sources, CachedResourceRequest.cpp is moved to a different combined source and is the first file included, so it doesn't get this header. I should have included this in an earlier patch, but I mistakenly thought it was just a build error in the tree at the time, so I worked around it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171208/2e54125a/attachment-0001.html>

More information about the webkit-unassigned mailing list